Allow passing the network directly to eval-machines.nix#258
Merged
srhb merged 2 commits intoDBCDK:masterfrom Jul 23, 2025
Merged
Allow passing the network directly to eval-machines.nix#258srhb merged 2 commits intoDBCDK:masterfrom
srhb merged 2 commits intoDBCDK:masterfrom
Conversation
Contributor
|
Hi @oskardotglobal, thanks for the PR. Can you give an example of how this would be used? |
Contributor
Author
|
You could write your own network parsing logic and then pass it to morph like # eval-machines.nix
import "${pkgs.morph.lib}/eval-machines.nix" {
network = {}; # call whatever here
networkExpr = null;
} |
Contributor
So just to clarify, it's for using |
Contributor
Author
|
it's for extending eval-machines |
srhb
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows users to re-use morph's
eval-machines.nixwith any amount of preprocessing sincenetworkExpris no longer a required argument ifnetworkis passed